Add stream::repeat_with() method #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
requested changes
Dec 8, 2020
There was a problem hiding this comment.
Thanks for the PR! This looks reasonable to me. Could you do the following?
- Rebase (to fix clippy fail)
- Apply my code suggestion (to fix build fail on old compilers)
- Move
replase_withrelated code fromrepeate.rsto a new filefutures-util/src/stream/repeat_with.rs. (futures-util usually has its own file for each combinator.)
taiki-e
added
C-feature-request
futures-util
S-waiting-on-author
taiki-e
removed
the
S-waiting-on-author
taiki-e
approved these changes
Dec 8, 2020
Merged
exrook
pushed a commit
to exrook/futures-rs
that referenced
this pull request
Apr 5, 2021
Co-authored-by: zhy <zhy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the element type of the stream you need does not implement Clone, or if you do not want to keep the repeated element in memory, you can instead use the repeat_with() function.