Implement Clone on With combinator #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider the following use-case of mpsc channels. There are two
categories of producers which produce items of two distinct types,
later unified in one using `With` combinator:
```
let (sender, receiver) = mspc::channel(100);
let download_status = sender.clone().with(|item| {
futures::future::ok(Status::Download(item))
});
let unpack_status = sender.clone().with(|item| {
futures::future::ok(Status::Unpack(item))
});
```
It would be convenient for `With` combinator to implement `Clone`,
since the underlying sink, `futures::channel::mpsc::Sender`,
implements it.
This change adds `#[derive(Clone)]` to `With` combinator
taiki-e
requested changes
Dec 13, 2020
taiki-e
added
C-feature-request
futures-util
S-waiting-on-author
Address review comments This change * Implements `Clone` for `With` manually since we don't want to have `U: Clone, Item: Clone` bounds. * Adds a test case for `Clone` implementation.
|
Thanks for the review.
Sure thing, please see the update. Also, I'm not familiar with the code style of the project, so please feel free to point out any slipups. |
taiki-e
added
A-sink
taiki-e
changed the title
Merged
exrook
pushed a commit
to exrook/futures-rs
that referenced
this pull request
Apr 5, 2021
Consider the following use-case of mpsc channels. There are two
categories of producers which produce items of two distinct types,
later unified in one using `With` combinator:
```
let (sender, receiver) = mspc::channel(100);
let download_status = sender.clone().with(|item| {
futures::future::ok(Status::Download(item))
});
let unpack_status = sender.clone().with(|item| {
futures::future::ok(Status::Unpack(item))
});
```
It would be convenient for `With` combinator to implement `Clone`,
since the underlying sink, `futures::channel::mpsc::Sender`,
implements it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following use-case of mpsc channels. There are two
categories of producers which produce items of two distinct types,
later unified in one using
Withcombinator:It would be convenient for
Withcombinator to implementClone,since the underlying sink,
futures::channel::mpsc::Sender,implements it.
This change adds
#[derive(Clone)]toWithcombinator