Use assert_* functions for all future/stream/sink/io combinators #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
assert1
branch
2 times, most recently
from
951ed2e
to
318f0d0
Compare
taiki-e
commented
Jan 17, 2021
Comment on lines
+257
to
+258
| // TODO: type mismatch resolving `<St as Stream>::Item == std::result::Result<Item, <Self as futures_sink::Sink<Item>>::Error>` | ||
| // assert_future::<Result<(), Self::Error>, _>(SendAll::new(self, stream)) |
There was a problem hiding this comment.
IIUC, this is not because the bounds are not satisfied, but because the compiler cannot resolve projection (assoc type).
There was a problem hiding this comment.
Since TryStream is sealed, I think it's safe to replace the TryStream bounds with Stream<Item = Result<..>> bounds, but for now, I'll leave it as it is.
Comment on lines
+1341
to
+1342
| // TODO: type mismatch resolving `<Self as futures_core::Stream>::Item == std::result::Result<<Self as futures_core::TryStream>::Ok, <Self as futures_core::TryStream>::Error>` | ||
| // assert_future::<Result<(), Self::Error>, _>(Forward::new(self, sink)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measures to prevent recurrence of #2311.
Refs: #2020
Closes #2320