Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert Send/Sync/Unpin for all public types #2323

Merged
merged 10 commits into from
Jan 19, 2021
Merged

Assert Send/Sync/Unpin for all public types #2323

merged 10 commits into from
Jan 19, 2021

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 17, 2021 •
edited
Loading

Measures to prevent recurrence of #2316.

Modules:

  • channel
  • compat
  • executor
  • future
  • io
  • lock
  • sink
  • stream
  • task

Closes #2319

@taiki-e taiki-e force-pushed the assert2 branch 3 times, most recently from d855f71 to dc49c82 Compare January 17, 2021 12:45
@taiki-e taiki-e marked this pull request as ready for review January 17, 2021 15:22
@taiki-e taiki-e added A-channel Area: futures::channel A-compat Area: futures::compat A-executor Area: futures::executor A-future Area: futures::future A-io Area: futures::io A-lock Area: futures::lock A-sink Area: futures::sink A-stream Area: futures::stream A-task Area: futures::task and removed A-channel Area: futures::channel A-compat Area: futures::compat A-executor Area: futures::executor A-future Area: futures::future A-io Area: futures::io A-lock Area: futures::lock A-sink Area: futures::sink A-stream Area: futures::stream A-task Area: futures::task labels Jan 17, 2021
@taiki-e taiki-e merged commit 1803948 into rust-lang:master Jan 19, 2021
@taiki-e taiki-e deleted the assert2 branch January 19, 2021 13:13
@taiki-e taiki-e mentioned this pull request Feb 26, 2021
Merged
@nvzqz
Copy link

nvzqz commented Feb 27, 2021

👀 I couldn't help but notice futures now depends on my crate. Glad you found it useful for impl asserts!

FYI, I do plan to have assert_impl! with trait expressions planned for next release whenever I get around to it. See impls for syntax examples.

exrook pushed a commit to exrook/futures-rs that referenced this pull request Apr 5, 2021
@taiki-e
Assert Send/Sync/Unpin for all public types (rust-lang#2323)
daa787a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add assertions for Send/Sync/Unpin
2 participants
@taiki-e @nvzqz