Change SelectAll iterators to return stream instead of StreamFuture #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
added
A-stream
taiki-e
force-pushed
the
stream-select_all
branch
from
ddeec92
to
3a09965
Compare
taiki-e
force-pushed
the
stream-select_all
branch
from
3a09965
to
097a390
Compare
|
ah nice, you newtyped the iterators, I was going to bring that up. |
taiki-e
added a commit
that referenced
this pull request
May 10, 2021
Merged
taiki-e
added
0.3-backport: completed
and removed
0.3-backport: pending
taiki-e
added a commit
that referenced
this pull request
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion from StreamFuture to the underlying stream always succeeds because FuturesUnordered removes completed futures. So, I think it makes sense and more useful that SelectAll iterators return stream instead of StreamFuture.
This also removes iter_pin_ref and iter_pin_mut, because SelectAll's streams are always Unpin.
cc #1964, #2428
FYI @ibraheemdev