-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement try_chunks #2438
Implement try_chunks #2438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I'm ok with adding such a feature, but I'm not sure if the behavior when an error occurs is good with this.
I feel it might be preferable to have our own error type that contains the error returned by the stream and the elements of the buffer at the time the error occurred.
What do you think?
Yeah, I thought about adding a tuple of all elements before error and the error itself, but my approach would lead to conversion of |
Sorry for lot's of intermediate commits and CI activation requests. I guess simple ID verification could be better for GitHub Actions 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
rust-lang#2438 is marked as `0.3-backport: pending`. This is it. :) Resolves rust-lang#1947 (which specifically mentionned 0.3)
Published in 0.3.16. |
Closes #1947