Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unreachable_pub false positives #2549

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 12, 2022

https://github.com/rust-lang/futures-rs/runs/4783724442?check_suite_focus=true

error: unreachable `pub` item
   --> futures/src/lib.rs:180:29
    |
180 |     pub use crate::future::{FutureExt as _, TryFutureExt as _};
    |     ---                     ^^^^^^^^^^^^^^
    |     |
    |     help: consider restricting its visibility: `pub(crate)`
    |
    = note: `-D unreachable-pub` implied by `-D warnings`
    = help: or consider exporting it for use by other crates

error: unreachable `pub` item
   --> futures/src/lib.rs:180:45
    |
180 |     pub use crate::future::{FutureExt as _, TryFutureExt as _};
    |     ---                                     ^^^^^^^^^^^^^^^^^
    |     |
    |     help: consider restricting its visibility: `pub(crate)`
    |
    = help: or consider exporting it for use by other crates

error: unreachable `pub` item
   --> futures/src/lib.rs:184:29
    |
184 |     pub use crate::stream::{StreamExt as _, TryStreamExt as _};
    |     ---                     ^^^^^^^^^^^^^^
    |     |
    |     help: consider restricting its visibility: `pub(crate)`
    |
    = help: or consider exporting it for use by other crates

error: unreachable `pub` item
   --> futures/src/lib.rs:184:45
    |
184 |     pub use crate::stream::{StreamExt as _, TryStreamExt as _};
    |     ---                                     ^^^^^^^^^^^^^^^^^
    |     |
    |     help: consider restricting its visibility: `pub(crate)`
    |
    = help: or consider exporting it for use by other crates

error: unreachable `pub` item
   --> futures/src/lib.rs:192:9
    |
191 |     pub use crate::io::{
    |     --- help: consider restricting its visibility: `pub(crate)`
192 |         AsyncBufReadExt as _, AsyncReadExt as _, AsyncSeekExt as _, AsyncWriteExt as _,
    |         ^^^^^^^^^^^^^^^^^^^^
    |
    = help: or consider exporting it for use by other crates

error: unreachable `pub` item
   --> futures/src/lib.rs:192:31
    |
191 |     pub use crate::io::{
    |     --- help: consider restricting its visibility: `pub(crate)`
192 |         AsyncBufReadExt as _, AsyncReadExt as _, AsyncSeekExt as _, AsyncWriteExt as _,
    |                               ^^^^^^^^^^^^^^^^^
    |
    = help: or consider exporting it for use by other crates

error: unreachable `pub` item
   --> futures/src/lib.rs:192:50
    |
191 |     pub use crate::io::{
    |     --- help: consider restricting its visibility: `pub(crate)`
192 |         AsyncBufReadExt as _, AsyncReadExt as _, AsyncSeekExt as _, AsyncWriteExt as _,
    |                                                  ^^^^^^^^^^^^^^^^^
    |
    = help: or consider exporting it for use by other crates

error: unreachable `pub` item
   --> futures/src/lib.rs:192:69
    |
191 |     pub use crate::io::{
    |     --- help: consider restricting its visibility: `pub(crate)`
192 |         AsyncBufReadExt as _, AsyncReadExt as _, AsyncSeekExt as _, AsyncWriteExt as _,
    |                                                                     ^^^^^^^^^^^^^^^^^^
    |
    = help: or consider exporting it for use by other crates

@@ -177,17 +177,20 @@ pub mod prelude {
pub use crate::stream::{self, Stream, TryStream};

#[doc(no_inline)]
#[allow(unreachable_pub)]
pub use crate::future::{FutureExt as _, TryFutureExt as _};
#[doc(no_inline)]
pub use crate::sink::SinkExt as _;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is interesting that only nested underscore imports are affected.

@taiki-e taiki-e merged commit 28c5577 into master Jan 12, 2022
@taiki-e taiki-e deleted the taiki-e/unreachable_pub branch January 12, 2022 14:46
taiki-e added a commit that referenced this pull request Feb 6, 2022
@taiki-e taiki-e mentioned this pull request Feb 6, 2022
taiki-e added a commit that referenced this pull request Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant