TryFlattenUnordered: propagate base stream error
#2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegnn
changed the title
FlattenUnordered: immediately propagate base stream errorsTryFlattenUnordered: immediately propagate base stream errors
olegnn
force-pushed
the
fu-propagate-base-stream-errors
branch
from
1f1e522
to
3f5c9a7
Compare
olegnn
force-pushed
the
fu-propagate-base-stream-errors
branch
2 times, most recently
from
7d7d45a
to
c681714
Compare
olegnn
changed the title
TryFlattenUnordered: immediately propagate base stream errorsTryFlattenUnordered: propagate base stream error
olegnn
force-pushed
the
fu-propagate-base-stream-errors
branch
8 times, most recently
from
b19ca3c
to
f0c1835
Compare
olegnn
force-pushed
the
fu-propagate-base-stream-errors
branch
from
f0c1835
to
b1b2071
Compare
olegnn
force-pushed
the
fu-propagate-base-stream-errors
branch
from
fc18bd9
to
c8f4866
Compare
taiki-e
added
the
0.3-backport: pending
olegnn
added a commit
to olegnn/futures-rs
that referenced
this pull request
Mar 11, 2023
taiki-e
pushed a commit
that referenced
this pull request
Mar 11, 2023
taiki-e
added
0.3-backport: completed
and removed
0.3-backport: pending
Merged
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 15, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [futures](https://rust-lang.github.io/futures-rs) ([source](https://github.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.26` -> `0.3.27` | --- ### Release Notes <details> <summary>rust-lang/futures-rs</summary> ### [`v0.3.27`](https://github.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#​0327---2023-03-11) [Compare Source](rust-lang/futures-rs@0.3.26...0.3.27) - Add `TryFlattenUnordered` ([#​2577](rust-lang/futures-rs#2577), [#​2590](rust-lang/futures-rs#2590), [#​2606](rust-lang/futures-rs#2606), [#​2607](rust-lang/futures-rs#2607)) - Add `AbortHandle::is_aborted` ([#​2710](rust-lang/futures-rs#2710)) - Add `AbortRegistration::handle` ([#​2712](rust-lang/futures-rs#2712)) - Make `BiLock` strict-provenance compatible ([#​2716](rust-lang/futures-rs#2716)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42LjAiLCJ1cGRhdGVkSW5WZXIiOiIzNS42LjAifQ==--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1816 Reviewed-by: crapStone <crapstone@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of allowing polling of the underlying stream after the error, propagate this error first, and only after it will be received by the caller, allow to continue polling.
The caller then will be able to either continue to poll the stream or abort due to the received error. This behavior is similar to the behavior of
try_buffer_unordered.