Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failure #2651

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Fix CI failure #2651

merged 2 commits into from
Oct 10, 2022

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 10, 2022

No description provided.

```
warning: unreachable `pub` item
  --> futures-util/src/stream/futures_unordered/mod.rs:25:32
   |
25 | pub use self::iter::{IntoIter, Iter, IterMut, IterPinMut, IterPinRef};
   | ---                            ^^^^
   | |
   | help: consider restricting its visibility: `pub(crate)`
   |
   = help: or consider exporting it for use by other crates
note: the lint level is defined here
  --> futures-util/src/lib.rs:11:5
   |
11 |     unreachable_pub
   |     ^^^^^^^^^^^^^^^

warning: unreachable `pub` item
  --> futures-util/src/stream/futures_unordered/mod.rs:25:38
   |
25 | pub use self::iter::{IntoIter, Iter, IterMut, IterPinMut, IterPinRef};
   | ---                                  ^^^^^^^
   | |
   | help: consider restricting its visibility: `pub(crate)`
   |
   = help: or consider exporting it for use by other crates
```
```
warning: casting to the same type is unnecessary (`usize` -> `usize`)
  --> futures-util/src/stream/stream/take.rs:57:37
   |
57 |         let lower = cmp::min(lower, self.remaining as usize);
   |                                     ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.remaining`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
   = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: casting to the same type is unnecessary (`usize` -> `usize`)
  --> futures-util/src/stream/stream/take.rs:60:28
   |
60 |             Some(x) if x < self.remaining as usize => Some(x),
   |                            ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.remaining`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`usize` -> `usize`)
  --> futures-util/src/stream/stream/take.rs:61:23
   |
61 |             _ => Some(self.remaining as usize),
   |                       ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.remaining`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
```
@taiki-e taiki-e merged commit baa6f30 into master Oct 10, 2022
@taiki-e taiki-e deleted the ci branch October 10, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant