Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fu: always replace inner wakers #2726

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

olegnn
Copy link
Contributor

@olegnn olegnn commented Mar 20, 2023

Fixes #2725.
As nested FlattenUnordered will be placed into a new future inside of FuturesUnordered every time its inner stream emits an item, its base stream's waker will point to an outdated task, and this will result in an inability to propagate the call properly.

@olegnn olegnn requested a review from taiki-e as a code owner March 20, 2023 20:31
@olegnn olegnn force-pushed the fu-always-replace-inner-wakers branch from 0505536 to 24d6c0a Compare March 20, 2023 20:41
@olegnn olegnn force-pushed the fu-always-replace-inner-wakers branch from 24d6c0a to 7e49a40 Compare March 20, 2023 20:42
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 066f1d0 into rust-lang:master Mar 22, 2023
@taiki-e taiki-e added A-stream Area: futures::stream 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Mar 22, 2023
@taiki-e taiki-e mentioned this pull request Mar 30, 2023
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Mar 30, 2023
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 30, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [futures](https://rust-lang.github.io/futures-rs) ([source](https://github.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.27` -> `0.3.28` |

---

### Release Notes

<details>
<summary>rust-lang/futures-rs</summary>

### [`v0.3.28`](https://github.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#&#8203;0328---2023-03-30)

[Compare Source](rust-lang/futures-rs@0.3.27...0.3.28)

-   Update to syn 2. This raises MSRV of utility crates to 1.56. ([#&#8203;2730](rust-lang/futures-rs#2730), [#&#8203;2733](rust-lang/futures-rs#2733))
-   Fix bug in `FlattenUnordered` ([#&#8203;2726](rust-lang/futures-rs#2726), [#&#8203;2728](rust-lang/futures-rs#2728))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yNC42IiwidXBkYXRlZEluVmVyIjoiMzUuMjQuNiJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1843
Reviewed-by: crapStone <crapstone@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nested flatten_unordered hangs
2 participants