-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unknown_lints and unused_imports warnings in test #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
taiki-e
commented
Mar 30, 2023
``` error: unknown lint: `useless_anonymous_reexport` --> futures/tests/no-std/src/lib.rs:3:10 | 3 | #![allow(useless_anonymous_reexport)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D unknown-lints` implied by `-D warnings` error: unused import: `futures_core::task::__internal::AtomicWaker as _` --> futures/tests/no-std/src/lib.rs:7:9 | 7 | pub use futures_core::task::__internal::AtomicWaker as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` error: unused import: `futures_channel::oneshot as _` --> futures/tests/no-std/src/lib.rs:15:9 | 15 | pub use futures_channel::oneshot as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: unused import: `futures::task::AtomicWaker as _` --> futures/tests/no-std/src/lib.rs:19:9 | 19 | pub use futures::task::AtomicWaker as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: unused import: `futures::stream::FuturesOrdered as _` --> futures/tests/no-std/src/lib.rs:23:9 | 23 | pub use futures::stream::FuturesOrdered as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: unused import: `futures_util::task::AtomicWaker as _` --> futures/tests/no-std/src/lib.rs:27:9 | 27 | pub use futures_util::task::AtomicWaker as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: unused import: `futures_util::stream::FuturesOrdered as _` --> futures/tests/no-std/src/lib.rs:31:9 | 31 | pub use futures_util::stream::FuturesOrdered as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```
taiki-e
added
the
0.3-backport: pending
The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet.
label
Mar 30, 2023
taiki-e
added a commit
that referenced
this pull request
Mar 30, 2023
``` error: unknown lint: `useless_anonymous_reexport` --> futures/tests/no-std/src/lib.rs:3:10 | 3 | #![allow(useless_anonymous_reexport)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D unknown-lints` implied by `-D warnings` error: unused import: `futures_core::task::__internal::AtomicWaker as _` --> futures/tests/no-std/src/lib.rs:7:9 | 7 | pub use futures_core::task::__internal::AtomicWaker as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` error: unused import: `futures_channel::oneshot as _` --> futures/tests/no-std/src/lib.rs:15:9 | 15 | pub use futures_channel::oneshot as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: unused import: `futures::task::AtomicWaker as _` --> futures/tests/no-std/src/lib.rs:19:9 | 19 | pub use futures::task::AtomicWaker as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: unused import: `futures::stream::FuturesOrdered as _` --> futures/tests/no-std/src/lib.rs:23:9 | 23 | pub use futures::stream::FuturesOrdered as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: unused import: `futures_util::task::AtomicWaker as _` --> futures/tests/no-std/src/lib.rs:27:9 | 27 | pub use futures_util::task::AtomicWaker as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: unused import: `futures_util::stream::FuturesOrdered as _` --> futures/tests/no-std/src/lib.rs:31:9 | 31 | pub use futures_util::stream::FuturesOrdered as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```
Merged
taiki-e
added
0.3-backport: completed
and removed
0.3-backport: pending
The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet.
labels
Mar 30, 2023
taiki-e
added a commit
that referenced
this pull request
Mar 30, 2023
``` error: unknown lint: `useless_anonymous_reexport` --> futures/tests/no-std/src/lib.rs:3:10 | 3 | #![allow(useless_anonymous_reexport)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D unknown-lints` implied by `-D warnings` error: unused import: `futures_core::task::__internal::AtomicWaker as _` --> futures/tests/no-std/src/lib.rs:7:9 | 7 | pub use futures_core::task::__internal::AtomicWaker as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` error: unused import: `futures_channel::oneshot as _` --> futures/tests/no-std/src/lib.rs:15:9 | 15 | pub use futures_channel::oneshot as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: unused import: `futures::task::AtomicWaker as _` --> futures/tests/no-std/src/lib.rs:19:9 | 19 | pub use futures::task::AtomicWaker as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: unused import: `futures::stream::FuturesOrdered as _` --> futures/tests/no-std/src/lib.rs:23:9 | 23 | pub use futures::stream::FuturesOrdered as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: unused import: `futures_util::task::AtomicWaker as _` --> futures/tests/no-std/src/lib.rs:27:9 | 27 | pub use futures_util::task::AtomicWaker as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: unused import: `futures_util::stream::FuturesOrdered as _` --> futures/tests/no-std/src/lib.rs:31:9 | 31 | pub use futures_util::stream::FuturesOrdered as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.