Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FuturesOrdered: Use 64-bit index #2810

Merged
merged 4 commits into from
Dec 7, 2023
Merged

FuturesOrdered: Use 64-bit index #2810

merged 4 commits into from
Dec 7, 2023

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Dec 7, 2023

Fixes #2689

@taiki-e
FuturesOrdered: Use 64-bit index
1340021
@taiki-e
Fix clippy::redundant_guards warning
af13916 
```
error: redundant guard
   --> futures-util/src/io/chain.rs:124:24
    |
124 |                 buf if buf.is_empty() => {
    |                        ^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards
    = note: `-D clippy::redundant-guards` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::redundant_guards)]`
help: try
    |
124 -                 buf if buf.is_empty() => {
124 +                 [] => {
    |
```
@taiki-e
Ignore clippy::test_attr_in_doctest lint
e2625d2 
```
error: unit tests in doctest are not executed
  --> futures-test/src/lib.rs:77:5
   |
77 |   /// #[test]
   |  _____^
78 | | /// fn my_test() {
   | |______________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#test_attr_in_doctest
   = note: `-D clippy::test-attr-in-doctest` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::test_attr_in_doctest)]`
```
@taiki-e
ci: Temporarily disable docs build
d1f1c7f
@taiki-e taiki-e added 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. A-stream Area: futures::stream labels Dec 7, 2023
@taiki-e taiki-e merged commit 02a4280 into master Dec 7, 2023
24 checks passed
@taiki-e taiki-e deleted the fo-index branch December 7, 2023 16:22
@taiki-e taiki-e mentioned this pull request Dec 24, 2023
Merged
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.3-backport: completed A-stream Area: futures::stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FuturesOrdered: handle index overflow correctly
1 participant
@taiki-e