Take &Arc instead of Arc in poll_future and poll_stream
#433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks great! This is a breaking change though so we'll hold off until 0.2 |
Closed
Member
|
I think it's actually looking like we're going to deprecate these functions in #436, so I'm going to close this. |
Member
|
(they'll just be removed for 0.2 anyway) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of issue #341 (fixes it?). As can be seen in the wait methods this prevents one
Arcclone for every polling after the first one. Did not benchmark but seems like a nice performance optimization. However this makes the syntax around polling complicated because one does not simply cast&Arc<T>to&Arc<Trait>.Thanks @stephaneyfx for helping me with the trait object magic in IRC.