Extract and export a standalone TaskRunner
#690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extracts the `TaskRunner` interface from the `current_thread` module to a standalone interface and also reexports it from the `executor` module. This is done with #675 as the primary motivation, namely accommodating crates using `CurrentThread` on foreign event loops like glib. In this situation Rust (and associated code) can't request to block (aka with `run_with_sleep`) and as a result need a nonblocking method (`TaskRunner::poll` here) instead. The `current_thread` module was then reimplemented in terms of `TaskRunner` to ensure there's no extra duplication.
alexcrichton
force-pushed
the
task-runner
branch
from
df6c5b3 to
2684d92
Compare
|
Work is happening on the 0.2 branch now, so closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extracts the
TaskRunnerinterface from thecurrent_threadmoduleto a standalone interface and also reexports it from the
executormodule. Thisis done with #675 as the primary motivation, namely accommodating crates using
CurrentThreadon foreign event loops like glib. In this situation Rust (andassociated code) can't request to block (aka with
run_with_sleep) and as aresult need a nonblocking method (
TaskRunner::pollhere) instead.The
current_threadmodule was then reimplemented in terms ofTaskRunnertoensure there's no extra duplication.
Closes #675