Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FutureExt::inspect_err method #908

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Add FutureExt::inspect_err method #908

merged 1 commit into from
Apr 2, 2018

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Mar 25, 2018

Fixes #898

cramertj
cramertj reviewed Apr 2, 2018
View reviewed changes
futures-util/src/future/mod.rs Outdated
/// # extern crate futures_executor;
/// use futures::prelude::*;
/// use futures::future;
/// use futures_executor::block_on;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in the other change, I'd use futures::executor rather than futures_executor.

@Nemo157
Copy link
Member Author

Nemo157 commented Apr 2, 2018

Updated

@cramertj
Copy link
Member

cramertj commented Apr 2, 2018

Thanks!

@cramertj cramertj merged commit 112672c into rust-lang:master Apr 2, 2018
@Nemo157 Nemo157 deleted the inspect_err branch April 2, 2018 19:56
@taiki-e taiki-e mentioned this pull request May 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cramertj cramertj cramertj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nemo157 @cramertj