Added support for creating constant Rvalues backed by different intiger sizes. #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoyo
reviewed
Jul 6, 2025
| @@ -2058,7 +2087,20 @@ gcc_jit_context_new_rvalue_from_long (gcc_jit_context *ctxt, | |||
| return ((gcc_jit_rvalue *)ctxt | |||
| ->new_rvalue_from_const <long> (numeric_type, value)); | |||
| } | |||
| #ifdef __SIZEOF_INT128__ | |||
There was a problem hiding this comment.
I believe the way we should handle the case where 128-bit integers are not supported is by adding an error and returning NULL: so the function would still be defined on targets that don't support them.
| @@ -2111,6 +2153,18 @@ gcc_jit_context_new_rvalue_from_double (gcc_jit_context *ctxt, | |||
| return ((gcc_jit_rvalue *)ctxt | |||
| ->new_rvalue_from_const <double> (numeric_type, value)); | |||
| } | |||
| gcc_jit_rvalue * | |||
There was a problem hiding this comment.
Suggested change
| gcc_jit_rvalue * | |
| gcc_jit_rvalue * |
| @@ -373,3 +373,10 @@ LIBGCCJIT_ABI_42 { | |||
| global: | |||
| gcc_jit_lvalue_add_attribute; | |||
| } LIBGCCJIT_ABI_41; | |||
| LIBGCCJIT_ABI_43 { | |||
There was a problem hiding this comment.
Suggested change
| LIBGCCJIT_ABI_43 { | |
| LIBGCCJIT_ABI_43 { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
gcc_jit_context_new_rvalue_from_int128,gcc_jit_context_new_rvalue_from_char,gcc_jit_context_new_rvalue_from_shortandgcc_jit_context_new_rvalue_from_float.This should hopefully allow us to create constant 128 bit ints more easily. The other functions are there for potential memory savings - rvalues backed by char's / shorts / floats instead of the larger types could be a bit smaller than their larger counterparts.