Add lvalue::set_name
#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoyo
reviewed
Aug 7, 2025
GuillaumeGomez
force-pushed
the
lvalue-set_name
branch
2 times, most recently
from
3d4552d to
822d7d3
Compare
|
Added the runtime error in case |
antoyo
reviewed
Aug 8, 2025
GuillaumeGomez
force-pushed
the
lvalue-set_name
branch
from
822d7d3 to
8033881
Compare
GuillaumeGomez
force-pushed
the
lvalue-set_name
branch
from
8033881 to
188f882
Compare
antoyo
reviewed
Aug 8, 2025
| #define TEST_ESCHEWS_SET_OPTIONS | ||
| static void set_options (gcc_jit_context *ctxt, const char *argv0) | ||
| { | ||
| gcc_jit_context_set_bool_option(ctxt, GCC_JIT_BOOL_OPTION_DEBUGINFO, 1); |
There was a problem hiding this comment.
This already seems to be set by the test harness.
Was there a reason to add it here?
There was a problem hiding this comment.
Making it explicit.
antoyo
pushed a commit
that referenced
this pull request
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.