Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Error::description #95

Merged

Conversation

AnderEnder
Copy link
Contributor

Error::description has been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon.

This PR:

  • Removes an implementation of Error::description

Related PR: rust-lang/rust#66919

Copy link
Contributor

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me

@KodrAus KodrAus merged commit 7692da7 into rust-lang:master Jan 11, 2020
@BurntSushi
Copy link
Member

Hmm, removing this is a breaking change I think. Was that intentional? (Although it's probably a pretty minor breaking change.)

@LukasKalbertodt
Copy link
Member

Does anyone know what the minimum Rust version of this crate was (before this PR)?

For error-chain we went with a solution that conditionally has the description method to avoid bumping the minimum required Rust version (final PR, previous PR with discussion).

@KodrAus
Copy link
Contributor

KodrAus commented Jan 11, 2020

Ah I assumed because we didn’t have a MSRV already, and because getopts is typically an app rather than library dependency, that we just weren’t tracking one and bumps to the Rust version were ok 🙂 That could have been a bad assumption to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants