Merge pull request #429 from rust-lang/cargo-fix

Relax credential helper checks
rust-lang · Jun 7, 2019 · a784fc7 · a784fc7
2 parents e1d5921 + 2241f53
commit a784fc7
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/cred.rs b/src/cred.rs
@@ -269,7 +269,7 @@ impl CredentialHelper {
 
         if cmd.starts_with('!') {
             self.commands.push(cmd[1..].to_string());
-        } else if cmd.starts_with('/') || cmd.starts_with('\\') || cmd[1..].starts_with(":\\") {
+        } else if cmd.contains("/") || cmd.contains("\\") {
             self.commands.push(cmd.to_string());
         } else {
             self.commands.push(format!("git credential-{}", cmd));
@@ -347,6 +347,7 @@ impl CredentialHelper {
             .stdin(Stdio::piped())
             .stdout(Stdio::piped())
             .stderr(Stdio::piped());
+        debug!("executing credential helper {:?}", c);
         let mut p = match c.spawn() {
             Ok(p) => p,
             Err(e) => {
@@ -360,6 +361,7 @@ impl CredentialHelper {
                     .stdin(Stdio::piped())
                     .stdout(Stdio::piped())
                     .stderr(Stdio::piped());
+                debug!("executing credential helper {:?}", c);
                 match c.spawn() {
                     Ok(p) => p,
                     Err(e) => {