Support for in-memory SSH keys is missing

[fooker]

libgit2 has support for in-memory SSH keys. There is already git2::SSH_MEMORY to indicate that the credentials type is allowed, but a wrapper for git_cred_ssh_key_memory_new is missing.

[JMLX42]

I this the corresponding PR was merged 7 days ago.
So I tried using 0.7.2which was released 5 days ago.

Yet I still get the following error message:

this version of libgit2 was not built with ssh memory credentials

[alexcrichton]

@promethe42 can you share snippets for how to reproduce to poke around?

[JMLX42]

@alexcrichton here you go:

pub fn git_credentials_callback(
    _user: &str,
    _user_from_url: Option<&str>,
    _cred: git2::CredentialType,
) -> Result<git2::Cred, git2::Error> {
    let user = _user_from_url.unwrap_or("git");

    if _cred.contains(git2::CredentialType::USERNAME) {
        return git2::Cred::username(user);
    }

    match env::var("GPM_SSH_KEY") {
        Ok(k) => {
            let key_path = path::Path::new(&k);

            if key_path.exists() {
                debug!("authenticate with user {} and private key located in {}", user, k);
                git2::Cred::ssh_key(user, None, key_path, None)
            } else {
                debug!("authenticate with user {} and private key stored in the GPM_SSH_KEY env var", user);
                git2::Cred::ssh_key_from_memory(user, None, &k, None)
            }
        },
        _ => Err(git2::Error::from_str("unable to get private key from GPM_SSH_KEY")),
    }
}

[JMLX42]

@alexcrichton The issue comes from libgit2-sys. The GIT_SSH_MEMORY_CREDENTIALS flag has to be defined:

cfg.define("GIT_SSH_MEMORY_CREDENTIALS", "ON");

[JMLX42]

@alexcrichton here is a PR that makes this feature actually usable: https://github.com/alexcrichton/git2-rs/pull/331

[JMLX42]

@alexcrichton thanks for merging the PR!

Any chance we can get a 0.7.4 with this fix anytime soon?

[alexcrichton]

sure thing, should be done now!