Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh_key_from_memory no longer respected #363

Open
mwhudson opened this issue Oct 19, 2018 · 4 comments · May be fixed by #1087
Open

ssh_key_from_memory no longer respected #363

mwhudson opened this issue Oct 19, 2018 · 4 comments · May be fixed by #1087

Comments

@mwhudson
Copy link

(Disclaimer: I'm very new at this)

It seems to me that one of the side effects of alexcrichton@76f4b74#diff-612b86ed90c06a3454760b47abd89aea was that the ssh_key_from_memory feature is no longer checked independently of the ssh feature, i.e. GIT_SSH_MEMORY_CREDENTIALS is always defined if GIT_SSH is. This broke my backport of cargo to an older release of Ubuntu where libssh2 is a bit old.
@alexcrichton
Copy link
Member

Oh oops, sorry about this! I was assuming that we'd always be building libssh2 from source (erroneously) and was looking to remove the opt-in needed for this API. Would it be possible to build libssh2 bundled like you're buliding libgit2 bundled?

@mwhudson
Copy link
Author

mwhudson commented Nov 5, 2018 •
edited
Loading

I guess so, but where does that end? In any case having the ssh_key_from_memory there but ignored definitely doesn't seem right! It seems very easy to respect it, I guess I can add a patch for that if you'd be willing to take it.

PS: sorry for the slow reply!

@alexcrichton
Copy link
Member

Oh sure yeah, either way's fine by me!

@martinvonz
Copy link

It's been a while and no one seems to have missed having the option to disable ssh_key_from_memory. Should we just delete the feature? Is the next version bump to 0.20.0 sufficient or do Rust projects prefer to just document features as deprecated?

martinvonz added a commit to martinvonz/git2-rs that referenced this issue Oct 2, 2024
@martinvonz
delete ineffective ssh_key_from_memory crate feature
91907f9 
The ssh_key_from_memory crate feature was added in commit 8ca0e92
(2018-07-26). Then it was accidentally made always-on in commit
76f4b74 (2018-09013). Since it seems like no one has missed the
ability to turn it off since then (not enough to send a PR anyway),
let's just delete the crate feature.

Closes rust-lang#363
@martinvonz martinvonz linked a pull request Oct 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

delete ineffective ssh_key_from_memory crate feature martinvonz/git2-rs
3 participants
@alexcrichton @mwhudson @martinvonz