work around for windows path separator for is_path_ignored #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/repo.rs
Outdated
| @@ -2540,4 +2554,18 @@ mod tests { | |||
| let _ = repo.clear_ignore_rules(); | |||
| assert!(!repo.is_path_ignored(Path::new("/foo")).unwrap()); | |||
| } | |||
|
|
|||
| #[test] | |||
| #[cfg(windows)] | |||
There was a problem hiding this comment.
Could the be listed below with an if cfg!(windows) guard instead?
src/repo.rs
Outdated
| @@ -2043,6 +2043,20 @@ impl Repository { | |||
| } | |||
|
|
|||
| /// Test if the ignore rules apply to a given path. | |||
| #[cfg(windows)] | |||
There was a problem hiding this comment.
Instead of #[cfg], could if cfg!(windows) be used to conditionally do the to_string_lossy instead?
|
Changes made. Also it looks like bild tymes are rather high, and rls reports significant time in |
|
Looks great, thanks! And yeah I'd be fine tweaking the build script if necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the workaround requested in #334 and therefore closes #334. When this is pushed we can proceed on rust-lang/cargo#5733.
I wish there was a way to do this that did not involve two extra allocations.
to_string_lossyandreplace.