Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more Windows paths. #557

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Apr 23, 2020

I missed a bunch of functions in #549 for converting windows paths to git repo paths.

@ehuss
Copy link
Contributor Author

ehuss commented Apr 23, 2020

Sorry Alex. 😞 I'm not sure if I had a brain fart or what, somehow I missed all the calls to into_c_string (I think I searched for IntoCString and then forgot to check the function calls.)

Needed for rust-lang/cargo#8095

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, and no worries! Wanna push again though to confirm CI is green?

@ehuss ehuss force-pushed the fix-more-windows-paths branch from b437a2a to b1eff9e Compare April 23, 2020 21:53
@ehuss
Copy link
Contributor Author

ehuss commented Apr 23, 2020

Yep, retriggered CI and it seems to be green.

@alexcrichton alexcrichton merged commit 6dde3eb into rust-lang:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants