Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify MatchOptions new() and default() function #101

Open
kangalio opened this issue Dec 22, 2020 · 1 comment
Open

Unify MatchOptions new() and default() function #101

kangalio opened this issue Dec 22, 2020 · 1 comment

Comments

@kangalio
Copy link

As per its documentation, MatchOptions' default values are these:

MatchOptions {
    case_sensitive: true,
    require_literal_separator: false,
    require_literal_leading_dot: false
}

However, its derived Default implementation gives this:

MatchOptions {
    case_sensitive: false,
    require_literal_separator: false,
    require_literal_leading_dot: false
}

This Default implementation doesn't do what it should, which is potentially very confusing. Fixing this is a breaking change though, so it should wait for 0.4

@KodrAus
Copy link
Contributor

KodrAus commented Jan 8, 2021

Ah that is very unfortunate ☹️ In the meantime we should note in the documentation that the behavior of Default is not the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants