Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a cache that remembers whether a given path is a file or a directory, based on the results of
std::fs::read_dir
. This reduces the number of executed syscalls and improves the performance of the library.Here is a simple benchmark that uses
glob
to find the amount of Rust files in thetests
directory of arustc
checkout.Results on my PC (approximately 19k Rust files are in that directory):
statx
syscall countBefore
After
Syscalls were measured with
strace <program> 2> out.txt && cat out.txt | wc -l
and time was measured usinghyperfine
.Fixes: #79
This pull request was created in cooperation with students of the Rust course on the VSB-TUO university.