Optimize Clone implementation #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amanieu
force-pushed
the
clone_from
branch
3 times, most recently
from
83de957 to
c3396c0
Compare
Amanieu
force-pushed
the
clone_from
branch
2 times, most recently
from
cb23a71 to
81b5f6e
Compare
Amanieu
changed the title
|
@bors r+ |
|
📌 Commit c9b320e has been approved by |
|
☀️ Test successful - checks-travis |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2020
Update hashbrown to 0.8.1 This update includes: - rust-lang/hashbrown#146, which improves the performance of `Clone` and implements `clone_from`. - rust-lang/hashbrown#159, which reduces the size of `HashMap` by 8 bytes. - rust-lang/hashbrown#162, which avoids creating small 1-element tables. Fixes rust-lang#28481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two major changes:
clone_fromis now implemented which can be used to skip memory allocation if the existingHashMapalready has enough capacity.T: Copyinto a simple memory copy.HashMapwhenclone_fromis used. Specialization is needed because theCloneimpl onHashMapis missingK: Hash + Eq, S: BuildHasher.Fixes #112