Hide allocator details and default to Global #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of the parallel iterators don't need the `S` hasher or `A` allocator at all if they convert to a tighter inner type upon construction. For those that do need `A`, default to `A=Global`.
|
@bors r+ |
|
📌 Commit dac885a has been approved by |
|
☀️ Test successful - checks-travis |
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change!
We no longer re-export the unstable allocator items from the standard library, nor the stable shims approximating the same. The choice was predicated on the "nightly" feature, but crates that did not set that feature could be forced into it by others in the dependency tree, and then fail for lack of
#![feature(allocator_api)]when referencing these items. All types have been audited to have a defaultA=Globalto make sure the type doesn't need to be named for stable users. Fixes #226.Many of the parallel iterators don't need the
Shasher orAallocator at all if they convert to a tighter inner type upon construction. This has been cleaned up, and those that do still needAnow default toA=Global.RawTable::with_capacityandtry_with_capacityhave moved back to being methods forGlobalonly. Newwith_capacity_inandtry_with_capacity_inmethods allow custom allocators, with theallocparameter last to match the similar methods onHashMapandHashSet.