Activate more features in clippy CI and fix new warnings #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but exclude clippy::mising_safety_doc and clippy::missing_errors_doc for now.
Member
Author
|
Looks good! Let’s add the fixes now… |
Member
Author
|
Should pass CI now. |
Member
Author
|
@Amanieu FYI, I’m done fixing clippy lints here for today, this can be merged :-) |
Member
|
@bors r+ |
Contributor
|
📌 Commit 33eedbd has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #288 (@Amanieu, you were too quick with the merge xD)
Add
rawfeature to clippy-tested features but excludeclippy::mising_safety_docandclippy::missing_errors_docfor now.These documentation lints require some nontrivial fixes, I guess I’ll open an issue.
I’ve got the fixes ready already, but let’s first test if CI failure works properly with the new lints activated…