Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Warn the user if they try to assign someone without review privileges #85

Closed
varkor opened this issue Jan 18, 2018 · 2 comments
Closed

Comments

@varkor
Copy link
Member

varkor commented Jan 18, 2018

Currently, if you r? a user who doesn't have the right to r+, rust-highfive will silently ignore it. This can be a little confusing: it'd be nicer if there was some indication of what went wrong.

@lcnr
Copy link
Contributor

lcnr commented Jun 11, 2020

Did this change or am I misinterpreting this issue 😅 I've gotten assign to a PR without having the right to r+ in rust-lang/rust#73254

@varkor
Copy link
Member Author

varkor commented Jun 12, 2020

Huh, it does seem to work now. I'll close unless there's any indication otherwise.

@varkor varkor closed this as completed Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants