Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

rust-lang/rust: Compiler review assignments based on the expert map #266

Closed
wants to merge 2 commits into from
Closed

rust-lang/rust: Compiler review assignments based on the expert map #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b7832a
rust-lang/rust: Remove outdated entries
petrochenkov Jun 3, 2020
2b8e7ba
rust-lang/rust: Review assignments based on the expert map
petrochenkov Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 67 additions & 9 deletions highfive/configs/rust-lang/rust.json
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
{
"groups": {
"all": [],
"compiler": ["@eddyb", "@petrochenkov", "@estebank", "@varkor", "@matthewjasper", "@davidtwco", "@ecstatic-morse"],
"syntax": ["@petrochenkov", "@eddyb"],
"libs": ["@sfackler", "@dtolnay", "@JoshTriplett", "@hanna-kruppe", "@withoutboats", "@cramertj", "@shepmaster", "@Mark-Simulacrum", "@kennytm", "@LukasKalbertodt"],
"compiler": ["@nikomatsakis", "@pnkfelix", "@eddyb", "@estebank", "@matthewjasper",
"@nagisa", "@oli-obk", "@petrochenkov", "@varkor", "@wesleywiser"],
"libs": ["@sfackler", "@dtolnay", "@JoshTriplett", "@hanna-kruppe", "@withoutboats",
"@cramertj", "@shepmaster", "@Mark-Simulacrum", "@kennytm", "@LukasKalbertodt"],
"infra-ci": ["@Mark-Simulacrum", "@kennytm", "@pietroalbini"],
"rustdoc": ["@steveklabnik", "@GuillaumeGomez", "@ollie27"]
},
Expand All @@ -17,18 +18,75 @@
"src/doc": ["doc"],
"src/etc": ["@Mark-Simulacrum"],
"src/liballoc": ["libs"],
"src/libarena": ["libs"],
"src/libcore": ["libs"],
"src/libfmt_macros": ["libs"],
"src/libgraphviz": ["@pnkfelix"],
"src/libpanic_abort": ["libs"],
"src/libpanic_unwind": ["libs"],
"src/libproc_macro": ["@petrochenkov"],
"src/librustc": ["compiler"],
"src/librustc_apfloat": ["@eddyb"],
"src/librustc_arena": ["@nnethercote", "libs"],
"src/librustc_ast": ["@petrochenkov", "@estebank", "@davidtwco"],
"src/librustc_ast_lowering": ["@oli-obk", "@davidtwco", "@ecstatic-morse"],
"src/librustc_ast_passes": ["compiler"],
"src/librustc_ast_pretty": ["@Mark-Simulacrum", "@petrochenkov"],
"src/librustc_attr": ["@petrochenkov"],
"src/librustc_builtin_macros": ["@petrochenkov"],
"src/librustc_codegen_llvm": ["@eddyb", "@cuviper", "@nagisa", "@wesleywiser"],
"src/librustc_codegen_ssa": ["@eddyb", "@petrochenkov", "@nagisa", "@ecstatic-morse",
"@wesleywiser"],
"src/librustc_data_structures": ["compiler", "@nnethercote"],
"src/librustc_driver": ["@Mark-Simulacrum"],
"src/librustc_error_codes": ["compiler"],
"src/librustc_errors": ["@estebank", "@oli-obk", "@davidtwco", "@spastorino"],
"src/librustc_expand": ["@petrochenkov", "@mark-i-m"],
"src/librustc_feature": ["compiler"],
"src/librustc_fs_util": ["compiler"],
"src/librustc_graphviz": ["@pnkfelix", "@ecstatic-morse"],
"src/librustc_hir": ["@eddyb", "@ecstatic-morse"],
"src/librustc_hir_pretty": ["@Mark-Simulacrum", "@petrochenkov"],
"src/librustc_incremental": ["@nikomatsakis", "@pnkfelix"],
"src/librustc_index": ["compiler"],
"src/librustc_infer": ["@nikomatsakis", "@eddyb", "@matthewjasper"],
"src/librustc_interface": ["@Mark-Simulacrum"],
"src/librustc_lexer": ["@petrochenkov", "@matklad"],
"src/librustc_lint": ["@davidtwco", "@oli-obk", "@varkor"],
"src/librustc_llvm": ["@cuviper", "@nagisa", "@pnkfelix"],
"src/librustc_macros": ["compiler"],
"src/librustc_metadata": ["@petrochenkov", "@eddyb"],
"src/librustc_middle": ["@oli-obk", "@RalfJung", "@eddyb", "@nikomatsakis",
"@nagisa", "@tmandry", "@pnkfelix", "@estebank",
"@matthewjasper", "@varkor", "@wesleywiser",
"@ecstatic-morse", "@jonas-schievink"],
"src/librustc_mir": ["@oli-obk", "@RalfJung", "@eddyb", "@nikomatsakis",
"@davidtwco", "@spastorino", "@nagisa", "@wesleywiser",
"@tmandry", "@pnkfelix", "@matthewjasper",
"@ecstatic-morse", "@jonas-schievink"],
"src/librustc_mir_build": ["@nikomatsakis", "@eddyb", "@oli-obk", "@davidtwco",
"@spastorino", "@matthewjasper", "@ecstatic-morse",
"@jonas-schievink", "@RalfJung", "@tmandry"],
"src/librustc_parse": ["@petrochenkov", "@estebank", "@davidtwco", "@varkor",
"@oli-obk"],
"src/librustc_parse_format": ["@estebank", "@matklad"],
"src/librustc_passes": ["compiler"],
"src/librustc_plugin_impl": ["@petrochenkov"],
"src/librustc_privacy": ["@petrochenkov"],
"src/librustc_query_system": ["@nikomatsakis", "@eddyb"],
"src/librustc_resolve": ["@petrochenkov", "@davidtwco", "@matthewjasper"],
"src/librustc_save_analysis": ["@Xanewok"],
"src/librustc_serialize": ["@nnethercote", "@eddyb"],
"src/librustc_session": ["@Mark-Simulacrum"],
"src/librustc_span": ["@petrochenkov", "@matthewjasper"],
"src/librustc_symbol_mangling": ["@eddyb"],
"src/librustc_target": ["@eddyb", "@nagisa", "@petrochenkov"],
"src/librustc_trait_selection": ["@nikomatsakis", "@scalexm", "@spastorino",
"@matthewjasper"],
"src/librustc_traits": ["@nikomatsakis", "@scalexm", "@spastorino",
"@matthewjasper"],
"src/librustc_ty": ["@nikomatsakis", "@scalexm", "@spastorino",
"@matthewjasper"],
"src/librustc_typeck": ["@nikomatsakis", "@eddyb", "@tmandry",
"@matthewjasper", "@varkor"],
"src/librustdoc": ["rustdoc"],
"src/libserialize": ["libs", "@erickt"],
"src/libstd": ["libs"],
"src/libsyntax": ["syntax"],
"src/libterm": ["libs"],
"src/libtest": ["libs"],
"src/llvm-project": ["@cuviper"],
Expand Down
4 changes: 0 additions & 4 deletions highfive/newpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,6 @@ def choose_reviewer(self, repo, owner, diff, exclude):
cur_dir = "/".join(parts[:2])

# A few heuristics to get better reviewers
if cur_dir.startswith('src/librustc'):
cur_dir = 'src/librustc'
if cur_dir == 'src/test':
cur_dir = None
if cur_dir and cur_dir not in counts:
Expand Down Expand Up @@ -333,8 +331,6 @@ def get_to_mention(self, diff):
full_dir = "/".join(parts)

# A few heuristics to get better reviewers
if cur_dir.startswith('src/librustc'):
cur_dir = 'src/librustc'
if cur_dir == 'src/test':
cur_dir = None
if len(full_dir) > 0:
Expand Down