This repository has been archived by the owner on Mar 14, 2023. It is now read-only.
Remove recommendation about how to add changes to the pull request #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Mark-Simulacrum maybe? The wording makes some confusing and blocks the above rustc-dev-guide's PR. |
|
Friendly-ping @Mark-Simulacrum, I remember you had some thoughts about this so I think you're one of the good reviewers here. |
|
Seems good to remove this for now, we'll see what effect(s) that has. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more context better read rust-lang/rustc-dev-guide#900 and check out the PR rust-lang/rustc-dev-guide#1111