This repository has been archived by the owner on Mar 14, 2023. It is now read-only.
Adjust reviewer selection to work on unprefixed group selection #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `r? compiler-team` or `r? pnkfelix` would not be matched by the regexes, which meant that they'd be silently ignored. `r? rust-lang/compiler-team` already worked, though. Note that if a user and team name overlap, then `r? @foo` will always map to foo the user, while `r? foo` will map to the team. Since we generally don't want the `@` prefix on team-wide pings, since it subscribes a bunch of people for no reason, it's nice to avoid necessarily typing the prefix as well. Users in practice do invoke the command in that way.
This was referenced Jan 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
r? compiler-teamorr? pnkfelixwould not be matched by the regexes, which meant that they'd be silently ignored.r? rust-lang/compiler-teamalready worked, though. Note that if a user and team name overlap, thenr? @foowill always map to foo the user, whiler? foowill map to the team.Since we generally don't want the
@prefix on team-wide pings, since it subscribes a bunch of people for no reason, it's nice to avoid necessarily typing the prefix as well. Users in practice do invoke the command in that way.