This repository was archived by the owner on Mar 14, 2023. It is now read-only.
Improve library team mention message for consistency #395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further continuations upon rust-lang/rust#95986.
I reviewed the output after the previous change to add the to_mention message for libs and wasn't thrilled with the output. It seemed to duplicate the welcome message that highfive posts generally as well as being very information dense. I've tried to reorder how we present information and reframe it so it flows well with the subsequent welcome message.
I tried reordering it all together so the welcome message comes first, but it appears that the
self.set_assignee
function needs to be called first beforeself.is_new_contributor
or else some of the state within the Handler ends up being a python dict instead of the expected JSON... Didn't feel like debugging or refactoring that, but I think I've arrived upon a wording that looks good even if it comes first. Also this way I don't necessarily mess up other team's welcome messages that may already be optimal if placed first.