This repository was archived by the owner on Mar 14, 2023. It is now read-only.
Remove @kennytm from libs reviewers #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I hope this isn't out of line at all -- while I don't really know them personally, I respect @kennytm a great deal, and have for a while now)
As noted in #416 (comment) @kennytm is pretty inactive. To quantify this, https://github.com/rust-lang/rust/pulls?q=is%3Apr+is%3Amerged+commenter%3Akennytm+%22approved+by+kennytm%22 says they've merged 3 reviews in the past year (EDIT: I think?). This is definitely an imperfect way to measure, but it seems infrequent enough that I think it's clear they're busy and the bot shouldn't auto-assign reviews to them.
(My motivation here is just that it ends up being a really bad contributor experience if they make a PR which gets assigned to an inactive reviewer -- this is most of why I go through the list of PR's assigned to them periodically)
@kennytm: Sorry if I've misinterpreted your availability! And to be clear, I think we'd be happy to re-add you to the review rotation if you'd like in the future. (And you can still r+ stuff, this PR just covers whether or not you're auto-assigned by the highfive bot)
CC @m-ou-se who probably should make the final call on this stuff, as the libs lead.