Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't unapprove my own PRs #40

Closed
matthiaskrgr opened this issue May 29, 2019 · 1 comment · Fixed by #42
Closed

can't unapprove my own PRs #40

matthiaskrgr opened this issue May 29, 2019 · 1 comment · Fixed by #42

Comments

@matthiaskrgr
Copy link
Member

People need to be able to r- their own PRs.

Use case:

I make a PR that updates clippy.
The PR is r+ed and prioritized.
In the meantime another rollup merges and breaks clippy again.
Now the clippy-pr needs to be updated again to a working version of clippy since it won't pass CI otherwise but I cannot prevent it from being tested and potentially waste 3 hours of CI time since I cannot r- PRs I authored.

rust-lang/rust#61298 (comment)

@kennytm
Copy link
Member

kennytm commented May 29, 2019

Note that you could workaround by close-and-reopen or push a new commit.

bryanburgers added a commit to bryanburgers/homu that referenced this issue May 30, 2019
Users want to be able to `r-` their own pull requests when they know the
change will not successfully pass, and want to unapprove before they
have time to push new code.

Users can already effectively unapprove their own pull requests via
other actions, like changing the target branch, pushing new commits, or
closing and re-opening. So allowing them to `r-` instead of having to
use a work-around should also be allowed.

Fixes rust-lang#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants