Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github3 to 3.2 release #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update github3 to 3.2 release #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
pull_request: {}

env:
PYTHON_VERSION: 3.8
PYTHON_VERSION: "3.10"

jobs:
cicd:
Expand Down
3 changes: 1 addition & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
FROM ubuntu:focal
# We need an older Ubuntu as github3 depends on < Python 3.10 to avoid errors
FROM ubuntu:jammy

RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
python3-pip \
Expand Down
8 changes: 2 additions & 6 deletions homu/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1627,9 +1627,7 @@ def synchronize(repo_label, repo_cfg, logger, gh, states, repos, db, mergeable_q
db,
states,
sha=comment.original_commit_id,
command_src=comment.to_json()['html_url'],
# FIXME switch to `comment.html_url`
# after updating github3 to 1.3.0+
command_src=comment.html_url
)

for comment in pull.iter_issue_comments():
Expand All @@ -1643,9 +1641,7 @@ def synchronize(repo_label, repo_cfg, logger, gh, states, repos, db, mergeable_q
my_username,
db,
states,
command_src=comment.to_json()['html_url'],
# FIXME switch to `comment.html_url`
# after updating github3 to 1.3.0+
command_src=comment.html_url
)

saved_state = saved_states.get(pull.number)
Expand Down
4 changes: 1 addition & 3 deletions homu/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,9 +478,7 @@ def github():
g.my_username,
g.db,
g.states,
command_src=c.to_json()['html_url'],
# FIXME switch to `c.html_url`
# after updating github3 to 1.3.0+
command_src=c.html_url
) or found

status = ''
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

packages=['homu'],
install_requires=[
'github3.py==0.9.6',
'github3.py==3.2.0',
'toml',
'Jinja2',
'requests',
Expand Down