Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support default implement method #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sherlock-Holo
Copy link

@Sherlock-Holo Sherlock-Holo commented Feb 4, 2024

that should fix #17

@tmandry
Copy link
Member

tmandry commented Jul 30, 2024

Thanks for your PR. Unfortunately I think it is too simplistic to land. In order to capture references to Self we will need where Self: Sync bounds (at least in the case of a Send trait.. in the general case, I think the type checker may not be up to the task, so we will have to keep it limited to Send for now). We also need to make sure arguments are moved into the async block, as is done in #20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async function with default implementation won't compile
2 participants