Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the dist-arm-linux job to arm runner #181

Closed
MarcoIeni opened this issue Dec 5, 2024 · 5 comments · Fixed by rust-lang/rust#133902
Closed

Move the dist-arm-linux job to arm runner #181

MarcoIeni opened this issue Dec 5, 2024 · 5 comments · Fixed by rust-lang/rust#133902

Comments

@MarcoIeni
Copy link
Member

MarcoIeni commented Dec 5, 2024

In rust CI, the dist-arm-linux job uses an x64 runner to cross-compile to arm.

Switch that job to use the large arm runner, similar to rust-lang/rust#133809 to improve performance.

bors added a commit to rust-lang-ci/rust that referenced this issue Dec 5, 2024
CI: move `dist-arm-linux` to a free runner

Related issue: rust-lang/infra-team#181

First, I want to test whether we could actually move this to a free runner, vs moving to the 8-core ARM runner.

r? `@MarcoIeni`

try-job: dist-arm-linux
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 5, 2024
CI: move `dist-arm-linux` to a free runner

Related issue: rust-lang/infra-team#181

First, I want to test whether we could actually move this to a free runner, vs moving to the 8-core ARM runner.

r? `@MarcoIeni`

try-job: dist-arm-linux
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 5, 2024
CI: move `dist-arm-linux` to a free runner

First, I want to test whether we could actually move this to a free runner, vs moving to the 8-core ARM runner.

Fixes: rust-lang/infra-team#181

r? `@MarcoIeni`

try-job: dist-arm-linux
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 5, 2024
CI: move `dist-arm-linux` to a free runner

First, I want to test whether we could actually move this to a free runner, vs moving to the 8-core ARM runner.

Fixes: rust-lang/infra-team#181

r? `@MarcoIeni`

try-job: dist-arm-linux
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 5, 2024
CI: move `dist-arm-linux` to a free runner

First, I want to test whether we could actually move this to a free runner, vs moving to the 8-core ARM runner.

Fixes: rust-lang/infra-team#181

r? `@MarcoIeni`

try-job: dist-arm-linux
jieyouxu added a commit to jieyouxu/rust that referenced this issue Dec 9, 2024
…Ieni

CI: move `dist-arm-linux` to an ARM runner

First, I want to test whether we could actually move this to a free runner, vs moving to the 8-core ARM runner.

Fixes: rust-lang/infra-team#181

r? `@MarcoIeni`

try-job: dist-arm-linux
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 10, 2024
CI: move `dist-arm-linux` to an ARM runner

First, I want to test whether we could actually move this to a free runner, vs moving to the 8-core ARM runner.

Fixes: rust-lang/infra-team#181

r? `@MarcoIeni`

try-job: dist-arm-linux
@Kobzol
Copy link

Kobzol commented Dec 10, 2024

The job is still being "cross-compiled" (using crosstool-ng), but it runs on an ARM runner now, thus saving CI cost. Implemented in rust-lang/rust#133902.

@Kobzol Kobzol closed this as completed Dec 10, 2024
@MarcoIeni
Copy link
Member Author

Should we remove crosstool-ng?

@Kobzol
Copy link

Kobzol commented Dec 10, 2024

Well, if it works, it seems more elegant than doing the whole CentOS 7 dance where we compile the world from scratch. So in fact I would like to try the opposite (rust-lang/rust#134118) and replace CentOS with crosstool, if it is possible.

@MarcoIeni
Copy link
Member Author

what about performance?
If we are already on arm, it seems a waste to cross compile to arm. Or am I missing something?

For the other runners, do you think it's worth to use arm to cross compile to x86 or there would be a performance penalty?

@Kobzol
Copy link

Kobzol commented Dec 10, 2024

I haven't measured if the cross-compilation is slower or not, so hard to say 🤷‍♂ Same for the other question. I wouldn't overdo it though, just because the ARM runner are cheaper, it doesn't mean that we have to use them everywhere, crosscompilation in general is probably contains a can of worms, especially when it's actually being done across platforms.

github-actions bot pushed a commit to rust-lang/miri that referenced this issue Dec 11, 2024
CI: move `dist-arm-linux` to an ARM runner

First, I want to test whether we could actually move this to a free runner, vs moving to the 8-core ARM runner.

Fixes: rust-lang/infra-team#181

r? `@MarcoIeni`

try-job: dist-arm-linux
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Dec 11, 2024
CI: move `dist-arm-linux` to an ARM runner

First, I want to test whether we could actually move this to a free runner, vs moving to the 8-core ARM runner.

Fixes: rust-lang/infra-team#181

r? `@MarcoIeni`

try-job: dist-arm-linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants