-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Impl Client::{supports_try_acquire, try_acquire}
#73
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not super familiar with the compatibility between these changes. It's better to have another pair of eyes. @petrochenkov do you have time to review?
P.S. I was trying to run
It seems to pretty persistent when using Edit: Issue is fixed after removing |
0e3082b
to
ff9cdb4
Compare
This was a bug in Cargo rust-lang/cargo#13647. A new nightly with that fix will be out today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clean up the branch's git history a bit? The "fix ..." commits likely won't help future readers through the history
ac8fbdf
to
b8dd5c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the workflow comment it LGTM now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
BTW, could you clean up the commit history again? Intermediate commits don't help much for future contributors (or future us 😆).
For me, I might break them into one for CI update, One for try_acquire
support, one for FIFO conversion optimization, and probably tests.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
so that we could set `O_NONBLOCK` on it. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
03020d4
to
46cc91d
Compare
With suggestions from @weihanglo Co-authored-by: Weihang Lo <weihanglo@users.noreply.github.com> Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
46cc91d
to
81195a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Resolve #72