Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the declarative macro repetition counts charter #45

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

markbt
Copy link
Contributor

@markbt markbt commented Aug 2, 2020

This is a charter for #28

Closes #28

The compiler already knows how many repetitions there are. What is
missing is a way to obtain it.

We propose to add syntax to allow this to be expressed directly:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably weaken this to say "We propose to add syntax to allow this to be expressed directly. As an initial suggestion, we are considering ${function(...)} where function can be countorindex` (and could potentially be used for other things in the future).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just that I think that project group charters should be a bit detached from the details of the proposals (it's not yet the RFC).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll reword it to remove the details. I'll leave the example in place, as I think it helps to compare it against the examples above, even if this is only the initial suggestion.

@nikomatsakis
Copy link
Contributor

Wording nits aside, I think this is good to go.

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented Aug 3, 2020

Team member @nikomatsakis has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot
Copy link
Collaborator

rfcbot commented Aug 27, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @nikomatsakis, I wasn't able to add the final-comment-period label, please do so.

@kennytm kennytm added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Aug 28, 2020
@rfcbot
Copy link
Collaborator

rfcbot commented Sep 6, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

psst @nikomatsakis, I wasn't able to add the finished-final-comment-period label, please do so.

@dtolnay dtolnay added finished-final-coment-period The FCP has finished, action upon the disposition label needs to be taken and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Sep 6, 2020
@nikomatsakis nikomatsakis merged commit fecbe7a into rust-lang:master Sep 30, 2020
@markbt markbt deleted the decl-macro-rep-count branch February 7, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
finished-final-coment-period The FCP has finished, action upon the disposition label needs to be taken T-lang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declarative macro repetition counts
5 participants