-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial draft of copy ergonomics design note #62
Conversation
I plan to open a second PR for the autoderef/autoref on operators, since it feels fairly orthogonal to copy ergonomics in general. |
Thanks for writing this up! @Mark-Simulacrum Annoyingly the GitHub UI refused to let me suggest additions as a PR, so I just pushed it. Feel free to rebase-disappear the updates if you dislike them. |
Please feel free to push :) Definitely not intended as a complete work. |
I think CI failure is just because I added coroutines to SUMMARY.md (previously they weren't being checked looks like) -- maybe @samsartor can take a look and patch that up? |
Yep, I totally missed that we were using mdbook. Just made #64 to fix that. |
cfa0c31
to
8eb529b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start! I have a few suggestions.
Added a few examples, as you suggested. |
0e3b34c
to
e50f4de
Compare
105f582
to
0502703
Compare
OK, I think this is ready to go -- updated per all the feedback given so far. r? @pnkfelix for another review? |
This looks good to me. I'm inclined to merge it as is. |
This draws mostly on readily available links in rust-lang/rust#44619.
r? @nikomatsakis
cc @rust-lang/lang