Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft of copy ergonomics design note #62

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

Mark-Simulacrum
Copy link
Member

This draws mostly on readily available links in rust-lang/rust#44619.

r? @nikomatsakis

cc @rust-lang/lang

@Mark-Simulacrum
Copy link
Member Author

I plan to open a second PR for the autoderef/autoref on operators, since it feels fairly orthogonal to copy ergonomics in general.

@scottmcm
Copy link
Member

scottmcm commented Oct 20, 2020

Thanks for writing this up!

@Mark-Simulacrum Annoyingly the GitHub UI refused to let me suggest additions as a PR, so I just pushed it. Feel free to rebase-disappear the updates if you dislike them.

@Mark-Simulacrum
Copy link
Member Author

Please feel free to push :)

Definitely not intended as a complete work.

@Mark-Simulacrum
Copy link
Member Author

I think CI failure is just because I added coroutines to SUMMARY.md (previously they weren't being checked looks like) -- maybe @samsartor can take a look and patch that up?

@samsartor
Copy link
Contributor

I think CI failure is just because I added coroutines to SUMMARY.md (previously they weren't being checked looks like) -- maybe @samsartor can take a look and patch that up?

Yep, I totally missed that we were using mdbook. Just made #64 to fix that.

Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start! I have a few suggestions.

src/design_notes/copy_ergonomics.md Show resolved Hide resolved
src/design_notes/copy_ergonomics.md Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member Author

Added a few examples, as you suggested.

@Mark-Simulacrum
Copy link
Member Author

OK, I think this is ready to go -- updated per all the feedback given so far. r? @pnkfelix for another review?

@pnkfelix
Copy link
Member

This looks good to me. I'm inclined to merge it as is.

@nikomatsakis nikomatsakis merged commit a3688a1 into rust-lang:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants