Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aarch64 fails with newer glibc (ipc_perm.mode) #231

Closed
posborne opened this issue Mar 15, 2016 · 2 comments · Fixed by #389
Closed

aarch64 fails with newer glibc (ipc_perm.mode) #231

posborne opened this issue Mar 15, 2016 · 2 comments · Fixed by #389

Comments

@posborne
Copy link
Contributor

I'm playing around with some changes that make it easier to run the tests for multiple architectures locally based on recent work merged into Nix. Running the build/tests in posborne/rust-cross:arm which is based on Ubuntu 15.10, this following error is received:

/data/aarch64-unknown-linux-gnu/debug/build/libc-test-2ff1f50e28187d2d/out/all.c: In function '__test_field_type_ipc_perm_mode':
/data/aarch64-unknown-linux-gnu/debug/build/libc-test-2ff1f50e28187d2d/out/all.c:9148:21: error: return from incompatible pointer type [-Werror]
                     return &b->mode;
                     ^
cc1: all warnings being treated as errors
thread '<main>' panicked at 'explicit panic', /root/.multirust/toolchains/1.7.0/cargo/registry/src/github.com-88ac128001ac3a9a/gcc-0.3.25/src/lib.rs:818

It appears that the type of struct ipc_perm.mode has a differnt type (mode_t I think). Not sure how best to handle. Simply changing the type to mode_t causes other failures.
@alexcrichton
Copy link
Member

How did glibc change in this regard? If it wasn't just switching to mode_t, did other pieces change as well?

@kamalmarhubi
Copy link
Contributor

Aside: @posborne I'm really excited for your testing changes here!

@japaric japaric mentioned this issue Aug 16, 2016
Closed
@japaric japaric mentioned this issue Sep 11, 2016
Merged
bors added a commit that referenced this issue Sep 12, 2016
@bors
Auto merge of #389 - japaric:aarch64, r=alexcrichton
36bec35 
aarch64: test against Ubuntu 16.04

also "backport" two glibc fixes:

- ipc_perm.mode is c_uint. [commit][1] [discussion][2]
- bump SIGSTKSZ to 16384. [commit][3] [discussion][4]

so libc-test passes.

[1]: https://sourceware.org/git/?p=glibc.git;a=commit;h=5c40c3bab2
[2]: https://www.sourceware.org/ml/libc-alpha/2014-10/msg00446.html
[3]: https://sourceware.org/git/?p=glibc.git;a=commit;h=b763f6ae859ecea70a5dacb8ad45c71d5f667e2e
[4]: https://sourceware.org/ml/libc-alpha/2015-04/msg00033.html

closes #231

r? @alexcrichton
@bors bors closed this as completed in #389 Sep 12, 2016
raphaelcohn pushed a commit to lemonrock/libc that referenced this issue Sep 15, 2016
@raphaelcohn
aarch64: test against Ubuntu 16.04
0a6f2a8 
also "backport" two glibc fixes:

- ipc_perm.mode is c_uint. [commit][1] [discussion][2]
- bump SIGSTKSZ to 16384. [commit][3] [discussion][4]

so libc-test passes.

[1]: https://sourceware.org/git/?p=glibc.git;a=commit;h=5c40c3bab2
[2]: https://www.sourceware.org/ml/libc-alpha/2014-10/msg00446.html
[3]: https://sourceware.org/git/?p=glibc.git;a=commit;h=b763f6ae859ecea70a5dacb8ad45c71d5f667e2e
[4]: https://sourceware.org/ml/libc-alpha/2015-04/msg00033.html

closes rust-lang#231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

aarch64: test against Ubuntu 16.04
3 participants
@posborne @kamalmarhubi @alexcrichton