Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI to ensure definitions are not removed #270

Closed
kamalmarhubi opened this issue Apr 28, 2016 · 2 comments
Closed

Add CI to ensure definitions are not removed #270

kamalmarhubi opened this issue Apr 28, 2016 · 2 comments
Assignees
@gnzlbg
Labels
A-CI Area: CI-related items

Comments

@kamalmarhubi
Copy link
Contributor

In #269 I moved some definitions around in the hierarchy, and ended up losing some functions for a while. Ideally we'd have something in CI that compares API coverage against TRAVIS_BRANCH / APPVEYOR_REPO_BRANCH to ensure we're only ever adding APIs.
@alexcrichton
Copy link
Member

Yeah I'd love to have a check like this!

On Wednesday, April 27, 2016, Kamal Marhubi notifications@github.com
wrote:

In #269 #269 I moved some
definitions around in the hierarchy, and ended up losing some functions for
a while. Ideally we'd have something in CI that compares API coverage
against TRAVIS_BRANCH / APPVEYOR_REPO_BRANCH to ensure we're only ever
adding APIs.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#270

@kamalmarhubi kamalmarhubi mentioned this issue Apr 28, 2016
Merged
Susurrus pushed a commit to Susurrus/libc that referenced this issue Mar 26, 2017
@homu
Auto merge of rust-lang#272 - abbradar:select-fixes, r=kamalmarhubi
614b0cb 
select(2) fixes

Part of rust-lang#270, fixed according to @kamalmarhubi's comments.
Susurrus pushed a commit to Susurrus/libc that referenced this issue Mar 26, 2017
@homu
Auto merge of rust-lang#274 - abbradar:new-syscalls, r=kamalmarhubi
7c00440 
New syscalls

Part of rust-lang#270
@gnzlbg gnzlbg added the A-CI Area: CI-related items label Nov 22, 2018
@gnzlbg gnzlbg self-assigned this Nov 22, 2018
@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 22, 2018

I'm going to try to use the rust-semverver crate to implement this.

gnzlbg added a commit to gnzlbg/libc that referenced this issue Nov 27, 2018
@gnzlbg
Verify that only non-technical breaking changes are applied to libc
fd6451d 
Closes rust-lang#270 .
@gnzlbg gnzlbg mentioned this issue Nov 27, 2018
Merged
gnzlbg added a commit to gnzlbg/libc that referenced this issue Feb 26, 2019
@gnzlbg
Verify that only non-technical breaking changes are applied to libc
f90c222 
Closes rust-lang#270 .
gnzlbg added a commit to gnzlbg/libc that referenced this issue Feb 26, 2019
@gnzlbg
Verify that only non-technical breaking changes are applied to libc
6fac01b 
Closes rust-lang#270 .
bors added a commit that referenced this issue Mar 2, 2019
@bors
Auto merge of #1154 - gnzlbg:semverver2, r=gnzlbg
1236fed 
Verify that only non-technical breaking changes are applied to libc

Closes #270 .

cc @alexcrichton so this would be a solution to #270 that uses rust-semverver to check that the API of `libc` contains only non-technical breaking changes.

This is a WIP and uses a fork of `rust-semverver` for now, but I've sent PRs upstream already. This is the only idea I have for solving #270 . `rust-semverver` is not perfect, but it can deal with functions, consts, and simple structs just fine, and that's pretty much everything that libc uses.

cc @ibabushkin

Some other notes:

* we have to compile `rust-semverver` for each toolchain version, and it depends on `cargo` so we have to build ~160 dependencies. Using `cache: cargo` breaks everything.
@bors bors closed this as completed in #1154 Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnzlbg gnzlbg

Labels
A-CI Area: CI-related items
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kamalmarhubi @alexcrichton @gnzlbg