Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libc documentation link is broken #427

Closed
omern1 opened this issue Oct 14, 2016 · 2 comments
Closed

Libc documentation link is broken #427

omern1 opened this issue Oct 14, 2016 · 2 comments

Comments

@omern1
Copy link

omern1 commented Oct 14, 2016

https://doc.rust-lang.org/libc/x86_64-unknown-linux-gnu/libc/index.html returns a 404

@alexcrichton
Copy link
Member

Hopefully addressed in #429, but I'll have to check back after it's merged.

@omern1
Copy link
Author

omern1 commented Oct 15, 2016

@alexcrichton It is working now.

@omern1 omern1 closed this as completed Oct 15, 2016
Susurrus pushed a commit to Susurrus/libc that referenced this issue Mar 26, 2017
call pipe2 directly on Linux

A first shot at fixing nix-rust/nix#414. This approach keeps the old implementation for platforms other than `notbsd`, because `libc` only exposes `pipe2` in the `notbsd` module.

I've tested this by hand on my Linux machine in a couple ways:

- Create a toy program that opens a pipe and passes it to `cat`, which hags if `O_CLOEXEC` doesn't get set properly. Confirm that it doesn't hang, but that it does if I pass `0` as the flags to `libc::pipe2`.
- Delete the new implementation entirely, and delete the `cfg` guards on the old implementation, and confirm that above is still true.

I haven't actually tested a cross compilation build though. Is there a standard way to do that?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants