-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Policy on new system calls? #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
New functions are definitely welcome! Adding them to this crate doesn't imply that they must be used, so it's up to downstream crates to use them or not. So in that sense PRs are definitely welcome! |
Add support for the `accept4` system call for FreeBSD* & NetBSD* As outlined in #540. However since support for this system call seems to be committed, but not yet released in NetBSD & BitRig (is BitRig actually still be developed at all, btw?), I'm not sure whether it wouldn't be a better idea to only add OpenBSD support instead? What's the official policy on this?
…borne fcntl: Support getting and setting pipe size on Linux
Can this be closed since #546 was merged? |
I guess so… The policy is basically "add whatever you want, as long as it exists in some released version of that platform". So the opening question of this issue has indeed been answered in the process of getting the PR merged, yes. |
I see that the
accept4
system call is currently exposed on Linux, but not on FreeBSD, OpenBSD or other system that support it. Here's the Unix compatibility story for that, IMHO quite useful, system call:git blame
on https://github.com/bitrig/bitrig/blame/master/sys/kern/syscalls.c, OTOH the BitRig 1.0 release page says it incorporates changes up to OpenBSD 5.6?, very unclear status in general IMHO…)Should these simply be submitted for any platform that supports them? Will that cause any issues for applications that target older platform?
Possibly related issues: #234
The text was updated successfully, but these errors were encountered: