Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmsg(3) bugs for musl and OSX #1235

Merged
merged 4 commits into from
Feb 5, 2019
Merged

Fix cmsg(3) bugs for musl and OSX #1235

merged 4 commits into from
Feb 5, 2019

Commits on Feb 5, 2019

  1. Fix CMSG_NXTHDR for OSX. 

    This was an oversight from PR rust-lang#1212.  It's been revealed by the new cmsg
test.
    @asomers
    asomers committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    73df81f View commit details
    Browse the repository at this point in the history

  2. Fix Linux's CMSG_NXTHDR and CMSG_SPACE definitions. 

    This is an error from PR rust-lang#1098.  The wrong definitions coincidentally
work on Linux/glibc, but fail on Linux/musl.
    @asomers
    asomers committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    4300666 View commit details
    Browse the repository at this point in the history

  3. Specialize CMSG_NXTHDR for Android and Emscripten

    @asomers
    asomers committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    eddc8d3 View commit details
    Browse the repository at this point in the history

  4. Add an integration test for the cmsg(3) functions. 

    Since these are defined in C as macros, they must be reimplemented in
libc as Rust functions.  They're hard to get exactly right, and they
vary from platform to platform.  The test builds custom C code that uses
the real macros, and compares its output to the Rust versions' output
for various inputs.

Skip the CMSG_NXTHDR test on sparc64 linux because it hits a Bus Error.

Issue rust-lang#1239

Skip the entire cmsg test program on s390x because it dumps core
seemingly before the kernel finishes booting.

Issue rust-lang#1240
    @asomers
    asomers committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    38cf5b1 View commit details
    Browse the repository at this point in the history