-
Notifications
You must be signed in to change notification settings - Fork 1.1k
x86_64-uclibc-l4re: fix syntax error + linter issues #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- fix syntax error in expand_align macro - fix errors due to doubly defined symbols / functions for x86_64-uclibc
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
LGTM! @bors: r+ Unrelated question, could you contribute the target-specification json file that you are using with xargo to build whatever application you are building ? If you could add it to the libc/ci directory we could build libc for this target, and make sure that at least compilation does not break for the target. Thanks! |
📌 Commit 2c18025 has been approved by |
x86_64-uclibc-l4re: fix syntax error + linter issues - fix syntax error in expand_align macro - fix errors due to doubly defined symbols / functions for x86_64-uclibc
💔 Test failed - checks-travis |
There are some style errors that should be fixed. |
Thanks, fixed.
|
@bors: retry |
@bors: r+ |
📌 Commit 3c8a493 has been approved by |
x86_64-uclibc-l4re: fix syntax error + linter issues - fix syntax error in expand_align macro - fix errors due to doubly defined symbols / functions for x86_64-uclibc
FYI i've added a test that checks that this target properly builds on CI here: #1296 |
☀️ Test successful - checks-cirrus, checks-travis, status-appveyor |
x86_64-uclibc