-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bunch of EOL docker images to Ubuntu 18.04 #1297
Conversation
r? @gnzlbg (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hard part of the upgrade is probably updating libc-test/build.rs
to remove all ignored APIs that are available in 18.04 but that are not available in 17.10. I'd guess that one can do that later.
Probably these 2 could go away once all the images are updated:
In fact this PR modifies API only for |
@bors: r+ |
📌 Commit 96eb1b2 has been approved by |
Thank you! |
Upgrade bunch of EOL docker images to Ubuntu 18.04 When upgrading other Dockerfiles (not modified in this PR) they fail with different errors: https://travis-ci.com/mati865/libc/jobs/181623075 https://travis-ci.com/mati865/libc/jobs/181623059 https://travis-ci.com/mati865/libc/jobs/181623067 I think it's because of these 2 commits in glibc: https://sourceware.org/git/?p=glibc.git;a=commit;h=b05cb613e7ae507680c8d914b3e788eea782c0d6 https://sourceware.org/git/?p=glibc.git;a=commit;h=2dba5ce7b8115d6a2789bf279892263621088e74 I have no idea how to fix them so leaving it for somebody who knows what to do.
☀️ Test successful - checks-cirrus, checks-travis, status-appveyor |
When upgrading other Dockerfiles (not modified in this PR) they fail with different errors:
https://travis-ci.com/mati865/libc/jobs/181623075
https://travis-ci.com/mati865/libc/jobs/181623059
https://travis-ci.com/mati865/libc/jobs/181623067
I think it's because of these 2 commits in glibc:
https://sourceware.org/git/?p=glibc.git;a=commit;h=b05cb613e7ae507680c8d914b3e788eea782c0d6
https://sourceware.org/git/?p=glibc.git;a=commit;h=2dba5ce7b8115d6a2789bf279892263621088e74
I have no idea how to fix them so leaving it for somebody who knows what to do.