Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add essential target_vendor check for sgx #1301

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Add essential target_vendor check for sgx #1301

merged 1 commit into from
Mar 11, 2019

Conversation

dingelish
Copy link
Contributor

As discussed in issue 57231, the current sgx branch only works for Fortanix's sgx platform. So the target_vendor should be checked here.

Signed-off-by: Yu Ding dingelish@gmail.com

Signed-off-by: Yu Ding <dingelish@gmail.com>
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gnzlbg
Copy link
Contributor

gnzlbg commented Mar 11, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 11, 2019

📌 Commit 21503ef has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Mar 11, 2019

⌛ Testing commit 21503ef with merge e1c9ad1...

bors added a commit that referenced this pull request Mar 11, 2019
Add essential target_vendor check for sgx

As discussed in issue [57231](rust-lang/rust#57231), the current `sgx` branch only works for Fortanix's sgx platform. So the `target_vendor` should be checked here.

Signed-off-by: Yu Ding <dingelish@gmail.com>
@bors
Copy link
Contributor

bors commented Mar 11, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing e1c9ad1 to master...

@bors bors merged commit 21503ef into rust-lang:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants