Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more posix message queue functions for Linux and all for solarish #1388

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

tormol
Copy link
Contributor

@tormol tormol commented Jun 3, 2019

I'm not able to run the tests locally (likely due to too old headers on Ubuntu 18.04), but I've tested my posixmq crate with these functions on Linux and OmniOS.

@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@gnzlbg
Copy link
Contributor

gnzlbg commented Jun 4, 2019

Linux test are passing, but we don't test Illuminos, Solaris, etc. on CI yet. @jasonbking would you be able to see if these tests pass for you there as well ?

@bors
Copy link
Contributor

bors commented Jun 4, 2019

☔ The latest upstream changes (presumably #1389) made this pull request unmergeable. Please resolve the merge conflicts.

@jasonbking
Copy link
Contributor

cargo test was successful on illumos -- was there any other specific testing you were interested in?

@gnzlbg
Copy link
Contributor

gnzlbg commented Jun 4, 2019

Did that run libc-test tests? Otherwise you might need to do cargo test --all, or cargo test --manifest-path libc-test/Cargo.toml.

@jasonbking
Copy link
Contributor

I'll look more this evening, but the ctest crate is throwing errors when building (because of LLVM issues, I'm still on 1.33, so not sure if that makes a difference).

@gnzlbg
Copy link
Contributor

gnzlbg commented Jun 7, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 7, 2019

📌 Commit bbcfd3c has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Jun 7, 2019

⌛ Testing commit bbcfd3c with merge 635ced1...

bors added a commit that referenced this pull request Jun 7, 2019
Add more posix message queue functions for Linux and all for solarish

I'm not able to run the tests locally (likely due to too old headers on Ubuntu 18.04), but I've tested my [posixmq crate](https://github.com/tormol/posixmq/tree/0decb7c82dd472024c7e90fd8121671881a81ae2) with these functions on Linux and OmniOS.
@bors
Copy link
Contributor

bors commented Jun 7, 2019

☀️ Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing 635ced1 to master...

@bors bors merged commit bbcfd3c into rust-lang:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants